[PATCH] D96290: [tools] UpdateTestPrefix: improved verbosity

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 11:05:33 PST 2021


spatel added a comment.

I've added a functionality question, but someone else should definitely look at the implementation because my python experience is minimal.



================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/prefix_warning_verbosity_nowarn.ll:5
+; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s \
+; RUN:   | FileCheck %s -check-prefixes=CHECK,RV64I
+
----------------
If we remove "RV64I" here, then the last 2 functions would have no assertions, right? Do we want to issue a warning for that scenario? Right now, it seems to be silent on that case by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96290/new/

https://reviews.llvm.org/D96290



More information about the llvm-commits mailing list