[PATCH] D96015: [RegAllocFast] Handle case where operand of copy cannot be assigned.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 10:17:18 PST 2021


aemerson added a comment.

In D96015#2549761 <https://reviews.llvm.org/D96015#2549761>, @qcolombet wrote:

> How was this test working before?
>
> Again I am not very keen on this approach because technically we could have this problem with any instruction and:
>
> 1. It doesn't make sense to support only COPY then
> 2. We really are doing the job of the scheduler here
>
> Note that SDISel does some scheduling, maybe the problem is there?

I'm not an expert in this area, but why is it any more job of the scheduler to keep the live ranges small for the sake of the allocator? Shouldn't the allocator be able to deal with any valid input (within computational reason)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96015/new/

https://reviews.llvm.org/D96015



More information about the llvm-commits mailing list