[PATCH] D96336: [AMDGPU] Save VGPR of whole wave when spilling

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 08:52:17 PST 2021


piotr added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1081
+    // Save exec and activate all lanes
+    BuildMI(*MBB, MI, DL, TII->get(ExecOrOpc), SavedExecReg).addImm(-1);
+
----------------
Not sure if that's a concern in this context, but doesn't it potentially clobber SCC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96336/new/

https://reviews.llvm.org/D96336



More information about the llvm-commits mailing list