[PATCH] D96340: Make fixed-abi default for AMD HSA OS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:386-388
+  // Override fixed-function ABI for HSA OS.
+  if (TT.getOS() == Triple::AMDHSA)
+    EnableFixedFunctionABI = true;
----------------
This isn't just changing the default, this is breaking the flag. You should check if the option wasn't specified


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96340/new/

https://reviews.llvm.org/D96340