[PATCH] D95985: [ELF] Resolve defined symbols before undefined symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In general, I think this looks okay. I've spent some time investigating the behaviour of our propietary linker in comparison to this, and it looks look the modified LLD matches our linker's behaviour, so this seems like a good thing for improving compatibility.

That being said, a colleague and I have been looking at whether there are any potential problemas this behaviour change might cause. We should be able to conclude that investigation tomorrow. Could you hold on until end of UK workday on Thursday before pushing this, please?



================
Comment at: lld/ELF/InputFiles.cpp:1204
+  // can trigger recursive fetch. Process defined symbols first so that a set of
+  // interconnected symbols will all be resolved to same file, instead of being
+  // resolved to different files.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95985/new/

https://reviews.llvm.org/D95985