[PATCH] D94677: [lld][WebAssembly] Common superclass for input globals/events/tables

Tue Feb 9 07:47:10 PST 2021

sbc100 added a comment.

lgtm with the base class rename.

Regarding the "requested changes" features,   I was going through all my outstanding reviews and trying to audit them all.   For any issue where the last set of comments were from me I thought it would make sense to mark like this to take it off my incoming queue.

================
Comment at: lld/wasm/InputDefinition.h:2
+//===- InputDefinition.h ----------------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
----------------
tlively wrote:
> sbc100 wrote:
> > I don't love the name "InputDefinition", but I don't have any great ideas for anything better.
> > 
> > Maybe @tlively has some thoughts?
> Would `InputItem` be better?
How about "InputElement" ?  I think we have used element elsewhere to refer to something that might be global or an event, etc.   See `ElementIndex` in `WasmSymbolInfo` for example.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94677/new/

https://reviews.llvm.org/D94677