[PATCH] D96184: [AIX][TLS] Generate TLS variables in assembly files

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 07:26:34 PST 2021


jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.

LGTM with minor nit.



================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2168
+                                     : Kind.isCommon() ? XCOFF::XMC_RW
+                                                       : XCOFF::XMC_UL;
+    return getContext().getXCOFFSection(Name, SMC, XCOFF::XTY_CM, Kind);
----------------
nit: reformat as the suggestion.


================
Comment at: llvm/lib/MC/MCSectionXCOFF.cpp:41
 
+  // Initialized TLS data
+  if (getKind().isThreadData()) {
----------------
nit:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96184/new/

https://reviews.llvm.org/D96184



More information about the llvm-commits mailing list