[PATCH] D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer updated this revision to Diff 322337.
StephenTozer added a comment.

Address review comments: remove unused `isReal`, add `hasLocNoGreaterThan` to prevent unnecessary modifications, replace messy vector storage of LocNo with simple C-style array, clean up messy `if` condition, use default-size SmallVectors where possible, renaming and formatting.

Still TODO: Add extra tests, prevent unnecessary cloning of arrays by reusing existing ones where possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83895/new/

https://reviews.llvm.org/D83895

Files:
  llvm/lib/CodeGen/LiveDebugVariables.cpp
  llvm/test/DebugInfo/MIR/X86/dvl-livedebugvars-movements.mir
  llvm/test/DebugInfo/MIR/X86/dvl-livedebugvars-stackptr.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-vars-unused-arg-debugonly.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83895.322337.patch
Type: text/x-patch
Size: 52080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210209/a8da2314/attachment.bin>