[PATCH] D96309: [AMDGPU] Refactor MIMG tables to better handle hardware variants

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks good to me, but there are also some TODOs in test/MC/Disassembler/AMDGPU/gfx10_mimg.txt which you should be able TO DO now.



================
Comment at: llvm/lib/Target/AMDGPU/MIMGInstructions.td:835
+defm IMAGE_ATOMIC_SUB           : MIMG_Atomic <mimgopc<0x12, 0x13, 0x12>, "image_atomic_sub">;
+defm IMAGE_ATOMIC_RSUB          : MIMG_Atomic <mimgopc<MIMG.NOP, MIMG.NOP, 0x13>, "image_atomic_rsub">;
+defm IMAGE_ATOMIC_SMIN          : MIMG_Atomic <mimgopc<0x14>, "image_atomic_smin">;
----------------
Needs asm/dis tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96309/new/

https://reviews.llvm.org/D96309