[PATCH] D96283: [DAGCombine] Do not remove masking argument to FP16_TO_FP for some targets

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

We already seem to have `shouldSignExtendTypeInLibCall` (used in the actual `ExpandLibCall` this code gets to) and `shouldExtendTypeInLibCall` (used in another expander I didn't know about). Ideally that's where we'd fix this issue by getting the generic call lowerer to insert a zext (which may be folded again later, if it's a sound transformation). Unfortunately because we only have an `i32` when the expansion happens I don't think that's possible.

But this seems like a much more targetted fix that only applies to this one f16 conversion so the name should probably reflect that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96283/new/

https://reviews.llvm.org/D96283