[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 00:20:40 PST 2021


jhenderson added a comment.

In D95916#2549306 <https://reviews.llvm.org/D95916#2549306>, @MaskRay wrote:

> I also started a topic with internal sanitizer folks why the "DATA" command was needed and whether it is still useful today. It'd be best if we can make data & functions behave the same way and drop "DATA" all together.

Please don't remove publicly facing features like this. We document this to our downstream users, and whilst I cannot say for certain whether we have any who use the DATA command, removing an option like this could potentially break people's workflows in non-trivial ways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916



More information about the llvm-commits mailing list