[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

[Jim Lin via Phabricator via llvm-commits]

Jim added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11127
+def err_riscvv_builtin_not_useable : Error<
+   "builtin requires 'V' extension support to be enabled">;
 } // end of sema component.
----------------
Add blank line.
Is it "err_riscvv_builtin_not_enabled"?


================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:89
+#define BUILTIN(ID, TYPE, ATTRS)                                               \
+  {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr},
+#include "clang/Basic/BuiltinsRISCV.def"
----------------
Builtins for other extension don't have "__builtin_rvv_" prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93446/new/

https://reviews.llvm.org/D93446