[PATCH] D96219: [CodeGen] Remove trailing dot of name of text section with prefix

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 21:41:12 PST 2021


MaskRay added a comment.

In D96219#2550331 <https://reviews.llvm.org/D96219#2550331>, @TaoPan wrote:

> Thanks! I got the trailing dot is for distinguishing text section name with prefix and function name with --function-sections.
> Is it ok adding comment to the code of adding trailing dot, like "For distinguishing between .text.${text-section-prefix}. (with trailing dot) and .text.${function-name}"?
>
> I'll submit another patch to fix the two dots issue of Summary in the place that connects text section name with prefix and function name.

Clarification patch sounds good..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96219/new/

https://reviews.llvm.org/D96219



More information about the llvm-commits mailing list