[PATCH] D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFYAML.cpp:94
+void MappingTraits<XCOFFYAML::Relocation>::mapping(IO &IO, XCOFFYAML::Relocation &R) {
+  IO.mapRequired("Address", R.VirtualAddress);
+  IO.mapRequired("Symbol", R.SymbolIndex);
----------------
MaskRay wrote:
> Seems that `r_vaddr` is an offset while called "vaddr". If it can often be 0, make it optional.
This specifies the address (as understood by the current object file) of the instruction or data which is to be modified by the relocation. That information is hardly optional. It is not the case that this represents an offset that modifies the "symbol" field. Such an offset is instead encoded within the instruction or data image in the current object file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95505/new/

https://reviews.llvm.org/D95505