[PATCH] D90970: Renovate CMake files in the `llvm-exegesis` tool.

Jameson Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 18:05:17 PST 2021


vtjnash updated this revision to Diff 322258.
vtjnash added a comment.

Okay, the first problem is because `add_llvm_library` doesn't support `STATIC`, so we need to use `llvm_add_library` instead (though it is also fixed by adding the missing `Support` dependency). The second problem is also missing dependency (for CommonTableGen).

With these updates, the STATIC linkage is also no longer required, though I've left that change for later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90970/new/

https://reviews.llvm.org/D90970

Files:
  llvm/tools/llvm-exegesis/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90970.322258.patch
Type: text/x-patch
Size: 5466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210209/d433a0ab/attachment.bin>


More information about the llvm-commits mailing list