[PATCH] D78796: [Support] Refactor LEB128 encoding into an input iterator
Nicolas Guillemot via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 8 16:05:49 PST 2021
nlguillemot added a comment.
In D78796#2549891 <https://reviews.llvm.org/D78796#2549891>, @dsanders wrote:
> I do wonder why do the logic and not the storage though.
At some point while working on this I tried putting all the members in a separate struct, but it kinda felt like duplicating code so I decided to leave it as is. Like you say, it might be an interesting refactor.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78796/new/
https://reviews.llvm.org/D78796
More information about the llvm-commits
mailing list