[PATCH] D96298: GlobalISel: Fix using wrong calling convention for callees

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 15:09:32 PST 2021


arsenm created this revision.
arsenm added reviewers: aemerson, paquette.
Herald added subscribers: kerbowa, pengfei, hiraditya, kristof.beyls, rovka, nhaehnle, jvesely.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was taking the calling convention from the parent function,
instead of the callee. Avoids regressions in a future patch when the
caller and callee have different type breakdowns.

      

For some reason AArch64's lowerFormalArguments seems to intentionally
ignore the parent isVarArg.


https://reviews.llvm.org/D96298

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96298.322226.patch
Type: text/x-patch
Size: 8509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210208/34a4ae96/attachment.bin>


More information about the llvm-commits mailing list