[PATCH] D95199: [ELF] Write output sections in PT_LOAD segment order

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 12:02:43 PST 2021


jrtc27 added inline comments.


================
Comment at: lld/test/ELF/linkerscript/out-of-order-sections.s:3
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: echo "PHDRS { \
+# RUN:           ph1 PT_LOAD; \
----------------
Without commenting on the changes to Writer.cpp, this is rather ugly and should probably be in a separate file. Certainly the formatting here is wrong with respect to closing curly braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95199/new/

https://reviews.llvm.org/D95199



More information about the llvm-commits mailing list