[PATCH] D96172: [flang][fir] Add shape, shape_shift, and slice types.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIRType.cpp:489
+};
+
 /// The type of a derived type part reference
----------------
schweitz wrote:
> mehdi_amini wrote:
> > MLIR has now the ability to auto-generate all this from TableGen, reducing drastically the boilerplate, can we move all these there? https://mlir.llvm.org/docs/OpDefinitions/#type-definitions
> Nice addition. How about going through all these types and using the new tablegen syntax for them all in a separate patch?
Sure, whatever works best for you here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96172/new/

https://reviews.llvm.org/D96172