[PATCH] D94308: [MachineSink] SinkIntoLoop: analyse stores and aliases in between

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:1093
 
 /// hasStoreBetween - check if there is store betweeen straight line blocks From
 /// and To.
----------------
I happened to notice betweeen -> between


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:1196
+  if (!SawStore)
+    HasStoreCache[BlockPair] = false;
+  return HasAliasedStore;
----------------
Can this set the HasStoreCache for the block if it hasn't seen all the instructions in it yet?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94308/new/

https://reviews.llvm.org/D94308