[PATCH] D96011: [NFC][Analysis] Change struct VecDesc to use ElementCount

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:1671-1672
+  // same as a scalar.
+  ScalableVF = 0;
+  FixedVF = 1;
   if (ScalarF.empty())
----------------
sdesmalen wrote:
> Can you define these as ElementCount (and change the interface to take an ElementCount instead of unsigned), and do the initialization before the call to getWidestVF?
Hi @sdesmalen, I did that initially but then I thought it seemed a bit unnecessary to have them as ElementCounts because the interface clearly defines one as fixed and the other as scalable. I can change them back to ElementCount - it just felt like we were doing redundant extra work that's all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96011/new/

https://reviews.llvm.org/D96011