[PATCH] D96144: [ELF] Add --dwarf32-before-dwarf64 to sort DWARF32 input sections before DWARF64

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I've re-read a fair amount of the previous llvm-dev thread.
One goal of doing a patch like this was to collect some performance data; do we have that?  In particular, performance data comparing link times with the option default-on versus default-off, so we can determine whether the difference is small enough that we should just do this processing unconditionally.

I'm also wondering whether it is reasonable to collect the is-32/64 characteristic of a section "along the way" during some other processing, rather than iterating over all input sections as a separate pass.  It would have to be during or after the phase that attaches the reloc section to the input section of course.



================
Comment at: lld/ELF/Driver.cpp:2417
 
+  partitionDwarf32AndDwarf64();
+
----------------
Would a TimeTraceScope be helpful here?  At least while gathering the initial performance data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96144/new/

https://reviews.llvm.org/D96144