[PATCH] D95985: [ELF] Resolve defined symbols before undefined symbols

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

I've put my approval down, as I think it is a worthwhile change to make regardless of whether the test case that had problems is strictly legal.

I think it will be worth waiting till Wednesday as that will have given people a week to object.



================
Comment at: lld/ELF/InputFiles.cpp:1137
   // Symbol resolution of non-local symbols.
+  SmallVector<size_t, 8> unds;
   for (size_t i = firstGlobal, end = eSyms.size(); i != end; ++i) {
----------------
I've seen quite a few objects with more than 8 undefined symbols, particularly older projects. Is it worth running a quick experiment to see what the distribution is like? For example the undefined symbols per object in a clang/llvm build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95985/new/

https://reviews.llvm.org/D95985