[PATCH] D95373: Replace vector intrinsics with call to vector library

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

@LukasSommerTu  are you also looking into unifying/removing the code in SLPVectorizer/LV to create library calls?



================
Comment at: llvm/include/llvm/CodeGen/ReplaceWithVeclib.h:22
+class ReplaceWithVeclib : public PassInfoMixin<ReplaceWithVeclib> {
+public:
+  PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
----------------
nit: I think the coding style recommends using `struct ` if all members are public.


================
Comment at: llvm/lib/CodeGen/ReplaceWithVeclib.cpp:72
+  // to the corresponding function from the vector library.
+  IRBuilder<> IRBuilder{&CI};
+  SmallVector<Value *> Args(CI.arg_operands());
----------------
nit: Why `IRBuilder{&CI}` here but `Args(CI.arg_operands())` below? can this just be `IRBuilder(&CI)` for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373