[PATCH] D95874: [TableGen] Temporary hack to add type checking for multiclass template arguments [DO NOT COMMIT]

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 07:17:13 PST 2021


RKSimon added a comment.

In D95874#2548514 <https://reviews.llvm.org/D95874#2548514>, @Paul-C-Anagnostopoulos wrote:

> Sorry, I still don't understand. In the case of the MSP430, the 'arith' multiclass template argument 'node' needed to be generalized from type SDNode to type SDPatternOperator. This is because some of the uses of 'arith' pass a value that is not an SDNode, but some other subclass of SDPatternOperator. What warning message do you want to see here?

Let's forget about it - it was just a suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95874/new/

https://reviews.llvm.org/D95874



More information about the llvm-commits mailing list