[PATCH] D96259: [AArch64] Use '//' as comment string for MSVC assembly

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: rnk, compnerd.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

As the actual MSVC toolset doesn't use the GAS-style assembly that Clang/LLVM produces and consumes, there's no reference for what string to use for e.g. comments when building with a MSVC triple.

This frees up the use of semicolon as separator string, just like was done for GNU targets in 23413195649d0cf6f3860ae8b5fb115b35032075. (Previously, both the separator and comment strings were set to the same, a semicolon.)

Compiler-rt extensively uses separator chars in its assembly, and that assembly should be buildable with clang-cl for MSVC too.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96259

Files:
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
  llvm/test/CodeGen/AArch64/cfguard-checks.ll
  llvm/test/CodeGen/AArch64/landingpad-ifcvt.ll
  llvm/test/CodeGen/AArch64/reloc-specifiers.mir
  llvm/test/CodeGen/AArch64/seh_funclet_x1.ll
  llvm/test/CodeGen/AArch64/win64-no-uwtable.ll
  llvm/test/CodeGen/AArch64/windows-extern-weak.ll
  llvm/test/CodeGen/AArch64/wineh-try-catch-nobase.ll
  llvm/test/CodeGen/AArch64/wineh-try-catch.ll
  llvm/test/MC/AArch64/coff-gnu.s
  llvm/test/MC/AArch64/coff-relocations.s
  llvm/test/MC/AArch64/coff-separator.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96259.322089.patch
Type: text/x-patch
Size: 13330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210208/c97036da/attachment.bin>