[PATCH] D96188: [ELF] Support aarch64_be

Mon Feb 8 04:58:56 PST 2021

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Changes LGTM.

I think the PLT32 relocation also needs to be write32 rather than write32le (https://github.com/ARM-software/abi-aa/blob/master/aaelf64/aaelf64.rst#575static-data-relocations) I couldn't immediately spot anything else missing.

================
Comment at: lld/ELF/Arch/AArch64.cpp:335
     checkInt(loc, val, 32, rel);
     write32le(loc, val);
     break;
----------------
I think PLT32 should be write as it is data (a 32-bit offset).

At the moment it is only used by Fuchsia for relative vtables so I wouldn't expect this to show up in linux.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96188/new/

https://reviews.llvm.org/D96188