[PATCH] D91972: Improve STRICT_FSETCC codegen in absence of no NaN

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-fcmp-no-nans-opt.ll:1
+; RUN: llc < %s -mtriple=arm64-eabi -enable-no-nans-fp-math | FileCheck %s
+
----------------
Since these tests run with `-enable-no-nans-fp-math`, I am wondering what condition we are testing:

  if ((FPMO && FPMO->hasNoNaNs()) || TM.Options.NoNaNsFPMath)

I guess that is `TM.Options.NoNaNsFPMath`, so do we have/need checks for `FPMO->hasNoNaNs()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91972/new/

https://reviews.llvm.org/D91972