[PATCH] D94976: [DWARF] Create subprogram's DIE in the unit specified by its DISubprogram

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

In D94976#2548292 <https://reviews.llvm.org/D94976#2548292>, @teemperor wrote:

> This probably also caused two debuginfo-tests to regress when running against LLDB (at least that's the only relevant commit in the change log)

That sounds a lot like it -- I'll get onto reverting then.

Maskrays reproducer ended up here https://reviews.llvm.org/D95617#2547111 I think, quoting:

Reproduce: https://gist.github.com/MaskRay/4c67b29bb038d5a016260437c9e25a7a

  # git revert -n 56fa34ae3570a34fd0f4c2cf1bfaf095da01a959 # revert the workaround
  % cat run.sh 
  #!/bin/sh -e
  llc -split-dwarf-file x.dwo -filetype=obj $1 -o x.o
  if llvm-dwarfdump -debug-gnu-pubnames x.o 2> log; then
    exit 1
  fi
  grep 'name lookup table at' log
  % ./run.sh a.ll
  error: name lookup table at offset 0x12cc has a terminator at offset 0x12da before the expected end at 0x12fd
     


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94976/new/

https://reviews.llvm.org/D94976