[PATCH] D95382: [VPlan] Make VPBlockBase a VPUser.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:381
 /// A VPBlockBase can be either a VPBasicBlock or a VPRegionBlock.
-class VPBlockBase {
+class VPBlockBase : public VPUser {
   friend class VPBlockUtils;
----------------
gilr wrote:
> Would it suffice for VPBlockBase to have a VPUser rather than being one? (may also align more easily with terminators in the future)
Good idea, I updated the code to use a VPUser member to just manage the CondBit for now. There is at least `VPValue *Predicate` which should be updated before making `VPBlockBase` a `VPUser`, if we ever want to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95382/new/

https://reviews.llvm.org/D95382