[PATCH] D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard marked 3 inline comments as done.
ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:681
+
+  getActionDefinitionsBuilder(G_DYN_STACKALLOC).customFor({{p0, s64}}).lower();
 
----------------
rovka wrote:
> Why is this custom only for {p0, s64} ? It seems all the existing tests for G_DYN_STACKALLOC are for {p0, s64}, so I'm not sure when the other case is even possible and why we can't use the probing then too.
This is the only combination of types emitted by the IR translator, but I guess this will emit a non-probed alloca if that ever changes, so I'll change it to assert that the types are what we expect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96006/new/

https://reviews.llvm.org/D96006