[PATCH] D95617: [DWARF] Inlined variables with no location should not have a DW_TAG_variable

Mon Feb 8 02:23:48 PST 2021

jmorse added a comment.

In D95617#2547069 <https://reviews.llvm.org/D95617#2547069>, @dblaikie wrote:

> In a separate/preparatory commit, perhaps you could add checks that these inlined formal parameters have DW_AT_location. (& adding the xfail for the architectures that don't have locations on these variables/parameters)
>
> & then this change won't have to touch that test, I think.

Added in e05c10380ce7 <https://reviews.llvm.org/rGe05c10380ce7c18d1a232dcc5baa7c10d8bd2bf6>, I'll leave it to soak for a bit, then put this patch back in.

In D95617#2547111 <https://reviews.llvm.org/D95617#2547111>, @MaskRay wrote:

> Reproduce: https://gist.github.com/MaskRay/4c67b29bb038d5a016260437c9e25a7a

[...]

> error: name lookup table at offset 0x12cc has a terminator at offset 0x12da before the expected end at 0x12fd

I think this was destined for D94976 <https://reviews.llvm.org/D94976> (the _other_ dwarf patch of mine that's going in and out), I'll copy it there and start investigating, thanks for the reproducer.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95617/new/

https://reviews.llvm.org/D95617