[PATCH] D95874: [TableGen] Temporary hack to add type checking for multiclass template arguments [DO NOT COMMIT]

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 01:41:51 PST 2021


RKSimon added a comment.

In D95874#2547012 <https://reviews.llvm.org/D95874#2547012>, @Paul-C-Anagnostopoulos wrote:

> So you want to know if a multiclass template argument type is a class that was never passed to that multiclass? But if there are two subclasses of that class that are passed to the multiclass, the parent class is the type that must be declared for the template argument.

On the patch review there was confusion as to why I could use the Intrinsic subclass in some places but others I had to generalize all the way to SDPatternOperator - some warnings to indicate when we've over-generalized the accepted class might be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95874/new/

https://reviews.llvm.org/D95874



More information about the llvm-commits mailing list