[PATCH] D95927: DebugInfo/Symbolize: Retrieve filename from the preceding STT_FILE for .symtab symbolization

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 00:46:26 PST 2021


jhenderson added a comment.

There are some pre-merge bot failures looking at this patch, although I guess some of them might be a patch ordering issue.

Do we have test cases for the following negative aspects where the symbol isn't used?

1. The symbol name can't be looked up due to a corrupt st_name value.
2. There are no STT_FILE symbols before the local symbol in question (possibly there may be some after).
3. The symbol is a global symbol, with an STT_FILE symbol before it.
4. The symbol has a corresponding STT_FILE symbol, but the name from .debug_line can be found.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95927/new/

https://reviews.llvm.org/D95927



More information about the llvm-commits mailing list