[PATCH] D95121: [lld-macho][NFC] refactor relocation handling

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: lld/MachO/Arch/X86_64.cpp:62
+         "invalid relocation type");
+  if (type < 0 || type >= relocAttrsArray.size())
+    return TargetInfo::invalidRelocAttrs;
----------------
gcc warns about this always being false since type is unsigned.
Can it be removed?

Similarly with the assert above, I suppose type >= 0 is always true and it can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95121/new/

https://reviews.llvm.org/D95121