[PATCH] D95291: [CostModel] Remove VF from IntrinsicCostAttributes

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 02:40:39 PST 2021


samparker added inline comments.


================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:102
 
 IntrinsicCostAttributes::IntrinsicCostAttributes(Intrinsic::ID Id,
                                                  const CallBase &CI,
----------------
dmgreen wrote:
> samparker wrote:
> > Could it help to further reduce complexity in TTI if we moved the vectorizer-specific changes into the vectorizer? (Assuming that constructors are one of the different ways at TTI is used by the vectorizer)
> I have given it a try, and ended up adjusting some of the other constructors at the same time. It doesn't feel like the cleanest thing in the world, but keeps the code in the vectorizer. Let me know what you think.
Cheers Dave!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95291/new/

https://reviews.llvm.org/D95291



More information about the llvm-commits mailing list