[PATCH] D96212: [Verifier] Allow DW_TAG_class_type/DW_TAG_union_type to have no filename

[Joachim Protze via Phabricator via llvm-commits]

protze.joachim added a comment.

I just compared the debug information generated for a build from 7630520ae <https://reviews.llvm.org/rG7630520ae3c5af3f3536a81740cf316d3a21304e> + this patch with a build from 7630520ae <https://reviews.llvm.org/rG7630520ae3c5af3f3536a81740cf316d3a21304e> + revert 189f3111 <https://reviews.llvm.org/rG189f311130da38acfe0a3b3b234fc10bd60e34d2>.

I diffed the generated .debug_info section for all binaries generated with `check-libarcher`. I used `readelf -wi` to extract the .debug_info section. The only difference is really just the `DW_AT_producer` attribute which is clear because the clang info contains the git hash.
So, at least for this small collection of OpenMP programs we don't loose debug information by 189f3111 <https://reviews.llvm.org/rG189f311130da38acfe0a3b3b234fc10bd60e34d2> + this patch.

This is all the information available for `kmp_cmplrdata_t` in the old and the new build:

  <1><6c2e3>: Abbrev Number: 29 (DW_TAG_union_type)
     <6c2e4>   DW_AT_name        : (indirect string, offset: 0xddd4): kmp_cmplrdata_t
     <6c2e8>   DW_AT_byte_size   : 8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96212/new/

https://reviews.llvm.org/D96212