[PATCH] D94387: Add new LLVMComponents CMake module.

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident added a comment.

Addressed a couple of comments and knocked llvm-config off of my todo list. It will need a couple more tweaks once I fix some of the other shared lib flags but is mostly as it should be (and tests pass now).



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1510
   list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream
-  add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH ${ARGN})
+  add_llvm_executable(${test_name}
+    IGNORE_EXTERNALIZE_DEBUGINFO
----------------
serge-sans-paille wrote:
> I agree with this diff, but given the size of this patch, it's probably better *not* to fix cosmetic stuff ;-) 
Ah, didn't realize I still had that diff. I believe I was doing an edit there that I backed out (after reformatting it).


================
Comment at: llvm/lib/CMakeLists.txt:59
 
 # Component post-processing
+#LLVMBuildGenerateCFragment(OUTPUT ${LLVMCONFIGLIBRARYDEPENDENCIESINC})
----------------
serge-sans-paille wrote:
> It's super nice that you manage to remove this post-processing step!
> But removing the `LLVMBuildGenerateCFragment` puzzles me... I don't see it being generated elsewhere :-)
There are a number of things on my todo list, and this was one. Pushing an update momentarily that fixes llvm-config. Here is my todo list: https://gist.github.com/stellaraccident/47b3ed28b8134bb0b6db2afbec7fc789#file-todo-md


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94387/new/

https://reviews.llvm.org/D94387