[PATCH] D95826: [SROA] Propagate correct TBAA/TBAA Struct offsets

[William Moses via Phabricator via llvm-commits]

wsmoses marked 2 inline comments as done.
wsmoses added inline comments.


================
Comment at: llvm/lib/Analysis/TypeBasedAliasAnalysis.cpp:782
+    // Don't include any triples that aren't in bounds
+    if (InnerOffset->getZExtValue() < Offset)
+      continue;
----------------
jeroen.dobbelaere wrote:
> What if the offset is inside the specified region instead of at the boundary ? Shouldn't we keep that with a 0 offset and adapted size ? Although keeping it is not strictly necessary, but then we will loose some tbaa information.
> 
> 
Good call, amended to include.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95826/new/

https://reviews.llvm.org/D95826