[PATCH] D96208: [AssumptionCache] Do not track llvm.assume calls (PR49043)

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 6 10:13:57 PST 2021


jdoerfert added a comment.

In D96208#2546963 <https://reviews.llvm.org/D96208#2546963>, @nikic wrote:

> LGTM as well. I'm okay with either this one or D96168 <https://reviews.llvm.org/D96168>. This is a direct fix for the bug, while D96168 <https://reviews.llvm.org/D96168> is more an improvement to avoid keeping nulled-out value handles around in the cache.

I'll do one after the other.If there is ever a compile time or other problem we can revisit the self updating set but don't run into this again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96208/new/

https://reviews.llvm.org/D96208



More information about the llvm-commits mailing list