[PATCH] D94976: [DWARF] Create subprogram's DIE in the unit specified by its DISubprogram

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D94976#2543257 <https://reviews.llvm.org/D94976#2543257>, @MaskRay wrote:

> Heads-up: this patch seems to cause malformed `.debug_gnu_pubnames` with -fsanitize=cfi -gsplit-dwarf with some internal targets. I will report back when I have done more investigation.
>
>   % llvm-dwarfdump -debug-gnu-pubnames spinlock.pic.o > /dev/null
>   error: name lookup table at offset 0x13d9 has a terminator at offset 0x13e7 before the expected end at 0x140a

Might've been more suitable to rollback the original patch rather than implementing an untested hack without a clear explanation for why the problem arises in the first place. (perhaps this papers over more fundamental issues, etc)

@jmorse - would you mind reverting both this patch and @MaskRay's workaround while a test case is being worked on? (sounds like @MaskRay is working on providing that, yeah?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94976/new/

https://reviews.llvm.org/D94976