[PATCH] D96098: [X86] Don't pass a 1 to the secon argument of ISD::FP_ROUND in LowerFCOPYSIGN.

Sat Feb 6 03:56:50 PST 2021

RKSimon added a comment.

In D96098#2545584 <https://reviews.llvm.org/D96098#2545584>, @craig.topper wrote:

> In D96098#2545540 <https://reviews.llvm.org/D96098#2545540>, @RKSimon wrote:
>
>> LGTM but I'd be happier if you can add a test case
>
> The use of that flag that I know of is to combine (fpext (fpround X, 1)) -> X if the type doesn't change. Since the FP_ROUND is being consumed by an expanded FCOPYSIGN after this, there won't be a fpext consuming it. Can you think of any other places it is used?

No sorry @spatel do you know ?

I'm OK for the patch to go without a test tbh.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96098/new/

https://reviews.llvm.org/D96098