[PATCH] D96168: [AssumptionCache] Avoid dangling llvm.assume calls in the cache
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 6 02:19:26 PST 2021
nikic added a comment.
Compile-time is in the noise: https://llvm-compile-time-tracker.com/compare.php?from=6e1afd858757256afdb619665befb790c76418bb&to=9f7b74f200bdee05bda1fbd9447ffd6fbd7c6262&stat=instructions I don't think CTMark generates many assumes though. In any case, I don't see anything here that should have a negative compile-time effect.
The patch looks fine to me, but I think I still haven't really understood at which point the problem is introduced in GVNSink. Could you point me to where the duplicate would get inserted?
================
Comment at: llvm/include/llvm/Analysis/AssumptionCache.h:51
+ /// calls in our cache.
+ class AssumeHandle : CallbackVH {
+ AssumptionCache *AC;
----------------
Missing final.
================
Comment at: llvm/include/llvm/Analysis/AssumptionCache.h:289
+ }
+};
+
----------------
Is it not sufficient to pass `DenseMapInfo<Value *>` as the second parameter to `DenseSet`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96168/new/
https://reviews.llvm.org/D96168
More information about the llvm-commits
mailing list