[PATCH] D96165: [WebAssembly] ensure .functype applies to right label in assembler

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 15:35:20 PST 2021


aardappel added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:227
-  // We track this to see if a .functype following a label is the same,
-  // as this is how we recognize the start of a function.
-  MCSymbol *LastLabel = nullptr;
----------------
sbc100 wrote:
> This comment seems like it might still be relevant to the remaining `LastFunctionLabel`?
It doesn't, because we don't require .functype to follow labels at all anymore. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96165/new/

https://reviews.llvm.org/D96165



More information about the llvm-commits mailing list