[PATCH] D95838: [WebAssembly] Prevent data inside text sections in assembly

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 13:52:38 PST 2021


sbc100 added inline comments.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1708
     Info.Name = WS.getName();
-    Info.Kind = WS.getType();
+    Info.Kind = WS.getType().getValueOr(wasm::WASM_SYMBOL_TYPE_DATA);
     Info.Flags = Flags;
----------------
So we still can end up with symbol that don't have exploit type and in that case we default to data symbols?   


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95838/new/

https://reviews.llvm.org/D95838



More information about the llvm-commits mailing list