[PATCH] D95838: [WebAssembly] Prevent data inside text sections in assembly

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 13:46:55 PST 2021


aardappel added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSymbolWasm.h:52
+  // the default. If possible, call getDefinedType instead, and/or ensure
+  // symbols always have the correct type set when constructed.
+  wasm::WasmSymbolType getType() const {
----------------
sbc100 wrote:
> Any reason to keep the deprecated method around?  Why not just remove it?     I guess a followup that removes it would be fine too.
Was able to get rid of the deprecated method.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95838/new/

https://reviews.llvm.org/D95838



More information about the llvm-commits mailing list