[PATCH] D96168: [AssumptionCache] Avoid dangling llvm.assume calls in the cache

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert created this revision.
jdoerfert added reviewers: jonpa, spatel, jmolloy, lebedev.ri, nikic.
Herald added a subscriber: hiraditya.
Herald added a reviewer: bollu.
jdoerfert requested review of this revision.
Herald added a project: LLVM.

PR49043 exposed a problem when it comes to RAUW llvm.assumes. While
D96106 <https://reviews.llvm.org/D96106> would fix it for GVNSink, it seems a more general concern. To
avoid future problems this patch moves away from the vector of weak
reference model used in the assumption cache. Instead, we track the
llvm.assume calls with a callback handle which will remove itself from
the cache if the call is deleted.

Fixes PR49043.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96168

Files:
  llvm/include/llvm/Analysis/AssumptionCache.h
  llvm/lib/Analysis/AssumptionCache.cpp
  llvm/lib/Analysis/CodeMetrics.cpp
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/lib/Transforms/Utils/PredicateInfo.cpp
  llvm/test/Analysis/AssumptionCache/basic.ll
  llvm/test/Transforms/GVNSink/assumption.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96168.321845.patch
Type: text/x-patch
Size: 12639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210205/29435681/attachment.bin>