[PATCH] D96122: [GlobalISel] Start using vectors in GISelKnownBits

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

I think lifting the `if (DstTy.isVector())` without testing all the cases it affects is a bit risky. LGTM if that's confirmed safe or if the check is sunk to the cases you didn't mean to affect



================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:143-144
 
-  if (DstTy.isVector())
-    return; // TODO: Handle vectors.
-
----------------
Is removing this safe for the other cases of the `switch (Opcode)` below? Cases like G_ADD/G_SUB haven't been tested on vectors yet and this patch doesn't test them. It may be safer to sink this to each case and remove it as we test each one


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96122/new/

https://reviews.llvm.org/D96122