[PATCH] D95444: Allow GNU inline asm using target-specific dialect variant

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D95444#2542739 <https://reviews.llvm.org/D95444#2542739>, @rnk wrote:

> Clang actually supports mixing GCC and MSVC inline asm in the same translation unit, and it uses the dialect flag in the IR to control this (I think). This is important if you want to support LTO between two TUs that use GCC and HLASM. Maybe there is exactly zero inline asm that uses GCC-style asm for SystemZ, so maybe this isn't a concern, but I thought I'd ask.

I'm concerned that "GCC" is overloaded here. The "GCC" that contrasts with MSVC is a C/C++ level parsing difference. The "GCC" that contrasts with HLASM has to do with the string content in a GNU-style inline assembly construct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95444/new/

https://reviews.llvm.org/D95444