[PATCH] D95980: [CSSPGO] Use merged base profile for hot threshold calculation

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

For debug info based CSSPGO, I assume the threshold should be the same, correct?



================
Comment at: llvm/lib/ProfileData/SampleProfWriter.cpp:766
   SampleProfileSummaryBuilder Builder(ProfileSummaryBuilder::DefaultCutoffs);
   for (const auto &I : ProfileMap) {
     const FunctionSamples &Profile = I.second;
----------------
ProfileMap --> *ProfilesToUse here? 

Actually the computeSummary in the Reader and the Writer are mostly the same. It is better to extract them and make it a shared function somewhere, for example in SampleProfileBuilder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95980/new/

https://reviews.llvm.org/D95980